feat: adds (no-)ignore-vsc-exclude #1652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AckslD
force-pushed
the
no-ignore-vsc-exclude
branch
from
e59ab54 to
08c42d7
Compare
tmccombs
requested changes
May 20, 2025
| @@ -78,6 +78,22 @@ pub struct Opts { | |||
| #[arg(long, overrides_with = "no_ignore_vcs", hide = true, action = ArgAction::SetTrue)] | |||
| ignore_vcs: (), | |||
|
|
|||
| ///Show search results from files and directories that | |||
| ///would otherwise be ignored by '.git/info/exclude'. | |||
| ///Git ignore files are still respected unless --no-ignore-vsc is given. | |||
There was a problem hiding this comment.
Suggested change
| ///Git ignore files are still respected unless --no-ignore-vsc is given. | |
| ///Git ignore files are still respected unless --no-ignore-vcs is given. |
| @@ -78,6 +78,22 @@ pub struct Opts { | |||
| #[arg(long, overrides_with = "no_ignore_vcs", hide = true, action = ArgAction::SetTrue)] | |||
| ignore_vcs: (), | |||
|
|
|||
| ///Show search results from files and directories that | |||
There was a problem hiding this comment.
Nit: Add space between the final "/" and thext of the comment
| help = "Do not respect .git/info/exclude", | ||
| long_help | ||
| )] | ||
| pub no_ignore_vcs_exclude: bool, |
There was a problem hiding this comment.
Let's call this "no_ignore_exclude" to match the name ripgrep uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1612
Let me know if this looks okay, if so I can add tests and update the docs.